Re: [PATCH v5] platform/x86: intel_pmc_core: export platform global reset bits via etr3 sysfs file

From: kernel test robot
Date: Sun Apr 11 2021 - 07:55:26 EST


Hi Tomas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Tomas-Winkler/platform-x86-intel_pmc_core-export-platform-global-reset-bits-via-etr3-sysfs-file/20210411-174433
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 52e44129fba5cfc4e351fdb5e45849afc74d9a53
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/b966c4184fd486407516000bf3151906318d29f6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tomas-Winkler/platform-x86-intel_pmc_core-export-platform-global-reset-bits-via-etr3-sysfs-file/20210411-174433
git checkout b966c4184fd486407516000bf3151906318d29f6
# save the attached .config to linux build tree
make W=1 ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/platform/x86/intel_pmc_core.c: In function 'etr3_is_visible':
>> drivers/platform/x86/intel_pmc_core.c:656:41: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
656 | return reg & ETR3_CF9LOCK ? attr->mode & SYSFS_PREALLOC | 0444 : attr->mode;


vim +656 drivers/platform/x86/intel_pmc_core.c

608
609 static int set_etr3(struct pmc_dev *pmcdev)
610 {
611 const struct pmc_reg_map *map = pmcdev->map;
612 u32 reg;
613 int err;
614
615 if (!map->etr3_offset)
616 return -EOPNOTSUPP;
617
618 mutex_lock(&pmcdev->lock);
619
620 /* check if CF9 is locked */
621 reg = pmc_core_reg_read(pmcdev, map->etr3_offset);
622 if (reg & ETR3_CF9LOCK) {
623 err = -EACCES;
624 goto out_unlock;
625 }
626
627 /* write CF9 global reset bit */
628 reg |= ETR3_CF9GR;
629 pmc_core_reg_write(pmcdev, map->etr3_offset, reg);
630
631 reg = pmc_core_reg_read(pmcdev, map->etr3_offset);
632 if (!(reg & ETR3_CF9GR)) {
633 err = -EIO;
634 goto out_unlock;
635 }
636
637 err = 0;
638
639 out_unlock:
640 mutex_unlock(&pmcdev->lock);
641 return err;
642 }
643 static umode_t etr3_is_visible(struct kobject *kobj,
644 struct attribute *attr,
645 int idx)
646 {
647 struct device *dev = container_of(kobj, struct device, kobj);
648 struct pmc_dev *pmcdev = dev_get_drvdata(dev);
649 const struct pmc_reg_map *map = pmcdev->map;
650 u32 reg;
651
652 mutex_lock(&pmcdev->lock);
653 reg = pmc_core_reg_read(pmcdev, map->etr3_offset);
654 mutex_unlock(&pmcdev->lock);
655
> 656 return reg & ETR3_CF9LOCK ? attr->mode & SYSFS_PREALLOC | 0444 : attr->mode;
657 }
658

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip