Re: [RFC PATCH v2 01/18] mm: memcontrol: fix page charging in page replacement

From: Shakeel Butt
Date: Sat Apr 10 2021 - 13:45:32 EST


On Fri, Apr 9, 2021 at 5:32 AM Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:
>
> The pages aren't accounted at the root level, so do not charge the page
> to the root memcg in page replacement. Although we do not display the
> value (mem_cgroup_usage) so there shouldn't be any actual problem, but
> there is a WARN_ON_ONCE in the page_counter_cancel(). Who knows if it
> will trigger? So it is better to fix it.
>
> Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>