Re: [Outreachy kernel] [PATCH v3] staging: rtl8192e: fixed pointer error by adding '*'

From: Julia Lawall
Date: Sat Apr 10 2021 - 10:02:44 EST




On Sat, 10 Apr 2021, Mitali Borkar wrote:

> Fixed pointer error by adding '*' to the function.
> Reported by Julia.

Actually, there is a proper tag for reported by, like Signed-off-by. Look
through the git history to see what to do.

julia

>
> Signed-off-by: Mitali Borkar <mitaliborkar810@xxxxxxxxx>
> ---
> Changes from v2:- modified patch body but writing commit message
> clearly.
> Changes from v1:- added pointer to the function.
>
> drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> index 4457c1acfbf6..78b5b4eaec5f 100644
> --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> @@ -327,7 +327,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
> }
>
> *ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect);
> - if (ppTS)
> + if (*ppTS)
> return true;
>
> if (!bAddNewTs) {
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHGvJxMhQ8nzHf6I%40kali.
>