Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

From: Greg KH
Date: Sat Apr 10 2021 - 09:14:28 EST


On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote:
> Fixed Comparison to NULL can be written as '!...' by replacing it with
> simpler form i.e. boolean expression. This makes code more readable
> alternative.
> Reported by checkpatch.

Checkpatch did not report this specific problem, Julia did :)

And this changelog text does not reflect the commit you made here.

>
> Signed-off-by: Mitali Borkar <mitaliborkar810@xxxxxxxxx>

We need a "Reported-by:" line here to reflect that someone reported the
problem as well.

Ideally it will have a "Fixes:" tag also, but I can add that if you
don't know how to do that just yet.

thanks,

greg k-h