Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

From: Jesper Dangaard Brouer
Date: Fri Apr 09 2021 - 16:40:24 EST


On Fri, 9 Apr 2021 22:01:51 +0300
Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx> wrote:

> On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote:
> > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote:
> > > Co-developed-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> > > Co-developed-by: Matteo Croce <mcroce@xxxxxxxxxxxxx>
> > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>
> >
> > Checkpatch says we need sign-offs from all authors.
> > Especially you since you're posting.
>
> Yes it does, we forgot that. Let me take a chance on this one.
> The patch is changing the default skb return path and while we've done enough
> testing, I would really prefer this going in on a future -rc1 (assuming we even
> consider merging it), allowing enough time to have wider tests.

You can have my:

Signed-off-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>

But as Ilias suggested in IRC lets send a V3, and Cc the MM-people, as
this also dig into their area.

--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer