Re: [PATCH] HSI: core: fix resource leaks in hsi_add_client_from_dt()

[Jason Gunthorpe]

On Fri, Apr 09, 2021 at 02:08:17PM +0300, Dan Carpenter wrote:
> If some of the allocations fail between the dev_set_name() and the
> device_register() then the name will not be freed.  Fix this by
> moving dev_set_name() directly in front of the call to device_register().
> 
> Fixes: a2aa24734d9d ("HSI: Add common DT binding for HSI client devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> Jason, this is the most common type of error I see with device_register().
> Is there a downside to calling dev_set_name() later?  Presumably it's
> printed out somewhere, but I feel like just moving the dev_set_name() is
> almost always the best and simplest fix.

It is hard to tell without detailed analysis.. ie a dev_err()/etc call
will use the name. It is why I don't like this design pattern of
avoiding device_initialize() and using device_registrR()

This movement looks OK though

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason