Re: [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device

From: Jason Gunthorpe
Date: Fri Apr 09 2021 - 13:32:21 EST


On Fri, Apr 09, 2021 at 08:24:00AM -0600, Alex Williamson wrote:

> > > #define DRIVER_VERSION "0.3"
> > > #define DRIVER_AUTHOR "Alex Williamson <alex.williamson@xxxxxxxxxx>"
> > > #define DRIVER_DESC "VFIO - User Level meta-driver"
> > >
> > > +#define VFIO_MAGIC 0x5646494f /* "VFIO" */
> > Move to include/uapi/linux/magic.h ?
>
> Hmm, yeah, I suppose it probably should go there. Thanks.

>From my review we haven't been doing that unless it is actually uapi
relavent for some reason (this is not)

In particular with CH having a patch series to eliminate all of these
cases and drop the constants..

Jason