Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions

From: David Howells
Date: Fri Apr 09 2021 - 08:35:54 EST


Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:

> iirc i looked at doing this as part of the folio work, and it ended up
> increasing the size of the kernel. Did you run bloat-o-meter on the
> result of doing this?

add/remove: 2/2 grow/shrink: 15/16 up/down: 408/-599 (-191)
Function old new delta
iomap_write_end_inline - 128 +128
try_to_free_swap 59 179 +120
page_to_index.part - 36 +36
page_size 432 456 +24
PageTransCompound 154 175 +21
truncate_inode_pages_range 791 807 +16
invalidate_inode_pages2_range 504 518 +14
ceph_uninline_data 969 982 +13
iomap_read_inline_data.isra 129 139 +10
page_cache_pipe_buf_confirm 85 93 +8
ceph_writepages_start 3237 3243 +6
hpage_pincount_available 94 97 +3
__collapse_huge_page_isolate 768 771 +3
page_vma_mapped_walk 1070 1072 +2
PageHuge 39 41 +2
collapse_file 2046 2047 +1
__free_pages_ok 449 450 +1
wait_on_page_bit_common 598 597 -1
iomap_page_release 104 103 -1
change_pte_range 818 817 -1
pageblock_skip_persistent 45 42 -3
is_transparent_hugepage 63 60 -3
nfs_readpage 486 482 -4
ext4_readpage_inline 155 151 -4
release_pages 640 635 -5
ext4_write_inline_data_end 286 281 -5
ext4_mb_load_buddy_gfp 690 684 -6
afs_dir_check 536 529 -7
page_trans_huge_map_swapcount 374 363 -11
io_uring_mmap 199 184 -15
io_buffer_account_pin 276 259 -17
page_to_index 50 - -50
iomap_write_end 375 306 -69
try_to_free_swap.part 137 - -137
PageUptodate 716 456 -260
Total: Before=17207139, After=17206948, chg -0.00%