Re: [PATCH] gpio: gpio-it87: remove unused code

From: Bartosz Golaszewski
Date: Fri Apr 09 2021 - 06:15:25 EST


On Tue, Apr 6, 2021 at 10:35 AM Simon Guinot <simon.guinot@xxxxxxxxxxxx> wrote:
>
> On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote:
> > Fix the following clang warning:
> >
> > drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
> > [-Wunused-function].
> >
> > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
>
> Acked-by: Simon Guinot <simon.guinot@xxxxxxxxxxxx>
>
> > ---
> > drivers/gpio/gpio-it87.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c
> > index 8f1be34..f332341 100644
> > --- a/drivers/gpio/gpio-it87.c
> > +++ b/drivers/gpio/gpio-it87.c
> > @@ -125,14 +125,6 @@ static inline int superio_inw(int reg)
> > return val;
> > }
> >
> > -static inline void superio_outw(int val, int reg)
> > -{
> > - outb(reg++, REG);
> > - outb(val >> 8, VAL);
> > - outb(reg, REG);
> > - outb(val, VAL);
> > -}
> > -
> > static inline void superio_set_mask(int mask, int reg)
> > {
> > u8 curr_val = superio_inb(reg);
> > --
> > 1.8.3.1

Patch applied, thanks!

Bartosz