Re: [PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng_probe()

From: Krzysztof Kozlowski
Date: Fri Apr 09 2021 - 02:17:26 EST


On Fri, 9 Apr 2021 at 08:11, Ye Weihua <yeweihua4@xxxxxxxxxx> wrote:
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Ye Weihua <yeweihua4@xxxxxxxxxx>

Hi,

The same Lukasz' comment applies here as for Qinglang's patch from
November 2020 - resume also needs fix up.

Best regards,
Krzysztof