Re: [PATCH net v1] Revert "lan743x: trim all 4 bytes of the FCS; not just 2"

From: Sven Van Asbroeck
Date: Thu Apr 08 2021 - 13:56:59 EST


Hi Heiner,

On Thu, Apr 8, 2021 at 1:49 PM Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote:
>
> Can't we use frame_length - ETH_FCS_LEN direcctly here?

If the hard-coded "4" refers to ETH_FCS_LEN, then yes, good point. I'd
love to find out first why George and I need different patches to make
the driver work in our use case, though.