Re: [PATCH net-next v3 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

From: Greg KH
Date: Thu Apr 08 2021 - 13:54:09 EST


On Thu, Apr 08, 2021 at 05:26:40PM +0000, Min Li wrote:
> >
> > Again, please make this only one file.
> >
> Hi Greg, the 2 boards have some same named registers in idt82p33_reg.h and idt8a340_reg.h
> so if I put them all in the same file, there will be name conflicts.

That does not make sense, this is only one kernel module, with one .h
file in this patch, I do not see those other files you are talking
about...

And if you have named registers that are identical, and yet you only
work on one device, that feels like a design flaw somewhere :)

thanks,

greg k-h