Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

From: Andy Shevchenko
Date: Wed Mar 31 2021 - 10:12:53 EST


On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer
<matthias.schiffer@xxxxxxxxxxxxxxx> wrote:
> On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote:
> > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer
> > <matthias.schiffer@xxxxxxxxxxxxxxx> wrote:

...

> > > + return 24000;
> >
> > AFAICS it will return 24 MHz for "Unknown" board. Is it okay to be so brave?
>
> As noted in the commit message, our hardware developers intend to use
> 24 MHz for all future x86 SoMs.

What may go wrong in the future?.. (rhetorical question, obviously)

--
With Best Regards,
Andy Shevchenko