Re: [PATCH v5] PCI: endpoint: Fix NULL pointer dereference for ->get_features()
From: Lorenzo Pieralisi
Date: Fri Mar 26 2021 - 11:24:20 EST
On Wed, 24 Mar 2021 15:46:09 +0530, Shradha Todi wrote:
> get_features ops of pci_epc_ops may return NULL, causing NULL pointer
> dereference in pci_epf_test_alloc_space function. Let us add a check for
> pci_epc_feature pointer in pci_epf_test_bind before we access it to avoid
> any such NULL pointer dereference and return -ENOTSUPP in case
> pci_epc_feature is not found.
>
> When the patch is not applied and EPC features is not implemented in the
> platform driver, we see the following dump due to kernel NULL pointer
> dereference.
>
> [...]
Applied to pci/endpoint, thanks!
[1/1] PCI: endpoint: Fix NULL pointer dereference for ->get_features()
https://git.kernel.org/lpieralisi/pci/c/6613bc2301
Thanks,
Lorenzo