Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3

From: Krzysztof Wilczyński
Date: Fri Mar 26 2021 - 03:46:40 EST


Hi,

> + /*
> + * Regarding to the datasheet, the PCIE_VPH is suggested
> + * to be 1.8V. If the PCIE_VPH is supplied by 3.3V, the
> + * VREG_BYPASS should be cleared to zero.
> + */
[...]

A small nitpick here. What about the following:

Regarding the data sheet, the PCIE_VPH is suggested to be 1.8V.
If the PCIE_VPH is supplied with 3.3V, the VREG_BYPASS should be
cleared to zero.

What do you think?

Krzysztof