Re: [RFT PATCH v3 13/27] arm64: Add Apple vendor-specific system registers

From: Hector Martin
Date: Fri Mar 26 2021 - 02:24:44 EST


On 25/03/2021 04.04, Will Deacon wrote:
On Wed, Mar 24, 2021 at 06:59:21PM +0000, Mark Rutland wrote:
So far we've kept arch/arm64/ largely devoid of IMP-DEF bits, and it
seems a shame to add something with the sole purpose of collating that,
especially given arch code shouldn't need to touch these if FW and
bootloader have done their jobs right.

Can we put the definitions in the relevant drivers? That would sidestep
any pain with MAINTAINERS, too.

If we can genuinely ignore these in arch code, then sure. I just don't know
how long that is going to be the case, and ending up in a situation where
these are scattered randomly throughout the tree sounds horrible to me.

I thought we would need some in KVM code, but given the direction Marc's series ended up in, it seems we won't. So I'm happy keeping these in the respective drivers; if this ends up being messy in the future it shouldn't be a big deal to refactor it all into one file again.

--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub