Re: [PATCH 00/25] Rid W=1 warnings from HID

[Srinivas Pandruvada]

On Wed, 2021-03-24 at 17:33 +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 

For changes in  drivers/hid/intel-ish-hid folder

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>

> Lee Jones (25):
>   HID: intel-ish-hid: Remove unused variable 'err'
>   HID: ishtp-hid-client: Move variable to where it's actually used
>   HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
>   HID: intel-ish: Supply some missing param descriptions
>   HID: intel-ish: Fix a naming disparity and a formatting error
>   HID: usbhid: Repair a formatting issue in a struct description
>   HID: intel-ish-hid: Fix a little doc-rot
>   HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
>   HID: hid-alps: Correct struct misnaming
>   HID: intel-ish-hid: Fix potential copy/paste error
>   HID: hid-core: Fix incorrect function name in header
>   HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name
> in
>     header
>   HID: ishtp-hid-client: Fix incorrect function name
> report_bad_packet()
>   HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
>   HID: hid-picolcd_core: Remove unused variable 'ret'
>   HID: hid-logitech-hidpp: Fix conformant kernel-doc header and
> demote
>     abuses
>   HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
>   HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
>   HID: hid-uclogic-params: Ensure function names are present and
> correct
>     in kernel-doc headers
>   HID: hid-sensor-custom: Remove unused variable 'ret'
>   HID: wacom_sys: Demote kernel-doc abuse
>   HID: hid-sensor-hub: Remove unused struct member 'quirks'
>   HID: hid-sensor-hub: Move 'hsdev' description to correct struct
>     definition
>   HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting
> issues
>   HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler
> warning
> 
>  drivers/hid/hid-alps.c                       |  2 +-
>  drivers/hid/hid-core.c                       |  2 +-
>  drivers/hid/hid-kye.c                        |  2 +-
>  drivers/hid/hid-logitech-hidpp.c             |  7 +--
>  drivers/hid/hid-picolcd_core.c               |  5 +--
>  drivers/hid/hid-sensor-custom.c              |  5 +--
>  drivers/hid/hid-sensor-hub.c                 |  4 +-
>  drivers/hid/hid-thrustmaster.c               | 24 +++++------
>  drivers/hid/hid-uclogic-params.c             |  8 ++--
>  drivers/hid/hid-uclogic-rdesc.c              |  2 +-
>  drivers/hid/intel-ish-hid/ipc/ipc.c          |  2 +-
>  drivers/hid/intel-ish-hid/ipc/pci-ish.c      |  3 +-
>  drivers/hid/intel-ish-hid/ishtp-fw-loader.c  | 45 ++++++++++------
> ----
>  drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
>  drivers/hid/intel-ish-hid/ishtp-hid.c        |  2 +-
>  drivers/hid/intel-ish-hid/ishtp-hid.h        |  9 +---
>  drivers/hid/intel-ish-hid/ishtp/bus.c        |  9 +++-
>  drivers/hid/intel-ish-hid/ishtp/client.c     |  5 +--
>  drivers/hid/intel-ish-hid/ishtp/hbm.c        |  4 +-
>  drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h  |  4 +-
>  drivers/hid/usbhid/hid-pidff.c               |  4 +-
>  drivers/hid/usbhid/usbkbd.c                  |  2 +-
>  drivers/hid/wacom_sys.c                      |  2 +-
>  include/linux/intel-ish-client-if.h          |  8 +++-
>  24 files changed, 90 insertions(+), 81 deletions(-)
> 
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> Cc: Anssi Hannula <anssi.hannula@xxxxxxxxx>
> Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> Cc: "Bruno Prémont" <bonbons@xxxxxxxxxxxxxxxxx>
> Cc: "Christian König" <christian.koenig@xxxxxxx>
> Cc: Daniel Drubin <daniel.drubin@xxxxxxxxx>
> Cc: Dario Pagani <dario.pagani.146+linuxk@xxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> Cc: Kim Kuparinen <kimi.h.kuparinen@xxxxxxxxx>
> Cc: "Krzysztof Wilczyński" <kw@xxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: linaro-mm-sig@xxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-iio@xxxxxxxxxxxxxxx
> Cc: linux-input@xxxxxxxxxxxxxxx
> Cc: linux-media@xxxxxxxxxxxxxxx
> Cc: linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: Lopez Casado <nlopezcasad@xxxxxxxxxxxx>
> Cc: "L. Vinyard, Jr" <rvinyard@xxxxxxxxxxx>
> Cc: Masaki Ota <masaki.ota@xxxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: message to <vojtech@xxxxxx>
> Cc: Michael Haboustak <mike-@xxxxxxxxxxxx>
> Cc: Rushikesh S Kadam <rushikesh.s.kadam@xxxxxxxxx>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> Cc: "Uwe Kleine-König" <uwe@xxxxxxxxxxxxxxxxx>
> Cc: Vojtech Pavlik <vojtech@xxxxxxx>
> Cc: Zhang Lixu <lixu.zhang@xxxxxxxxx>