Re: [PATCH] iio: adc: ad7292: Modify the bool initialization assignment

From: Marcelo Schmitt
Date: Sat Mar 20 2021 - 10:22:16 EST


Okay, looks good to me.

Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>

On 03/19, Guoqing chi wrote:
> From: Guoqing Chi <chiguoqing@xxxxxxxxxx>
>
> A bool initializer is best assigned to false rather than 0.
>
> Signed-off-by: Guoqing Chi <chiguoqing@xxxxxxxxxx>
> ---
> drivers/iio/adc/ad7292.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
> index 70e33dd1c9f7..3271a31afde1 100644
> --- a/drivers/iio/adc/ad7292.c
> +++ b/drivers/iio/adc/ad7292.c
> @@ -260,7 +260,7 @@ static int ad7292_probe(struct spi_device *spi)
> struct ad7292_state *st;
> struct iio_dev *indio_dev;
> struct device_node *child;
> - bool diff_channels = 0;
> + bool diff_channels = false;
> int ret;
>
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> --
> 2.17.1
>
>