Re: [PATCH] clang-format: Update ColumnLimit
From: Ansuel Smith
Date: Fri Mar 19 2021 - 14:46:32 EST
On Fri, Mar 19, 2021 at 11:42:34AM -0700, Nathan Chancellor wrote:
> On Fri, Mar 19, 2021 at 07:37:14PM +0100, Ansuel Smith wrote:
> > Update ColumnLimit value, changed from 80 to 100.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > ---
> > .clang-format | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.clang-format b/.clang-format
> > index c24b147cac01..3212542df113 100644
> > --- a/.clang-format
> > +++ b/.clang-format
> > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
> > #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
> > BreakAfterJavaFieldAnnotations: false
> > BreakStringLiterals: false
> > -ColumnLimit: 80
> > +ColumnLimit: 100
> > CommentPragmas: '^ IWYU pragma:'
> > #CompactNamespaces: false # Unknown to clang-format-4.0
> > ConstructorInitializerAllOnOneLineOrOnePerLine: false
> > --
> > 2.30.2
> >
>
> Not sure how opinions have changed since but this has come up before:
>
> https://lore.kernel.org/r/20200610125147.2782142-1-christian.brauner@xxxxxxxxxx/
>
Sorry, didn't notice that. Considering that checkpatch complains and
some reviewers actually state that 100 is the new limit, I think it's
time to update the file.
> Cheers,
> Nathan