Re: [PATCH 2/2] iommu: Streamline registration interface
From: Christoph Hellwig
Date: Fri Mar 19 2021 - 09:43:38 EST
> +int iommu_device_register(struct iommu_device *iommu, const struct iommu_ops *ops,
It would be nice to avoid the pointlessly overlong line here.
> + struct device *hwdev)
> {
> + iommu->ops = ops;
> + if (hwdev)
> + iommu->fwnode = hwdev->fwnode;
This function could use a kerneldoc comment now. Especially the hwdev
agument isn't exactly obvious.