Re: [PATCH v2 4/6] dt-bindings: PCI: Add SiFive FU740 PCIe host controller
From: Krzysztof Wilczyński
Date: Thu Mar 18 2021 - 23:56:55 EST
Hi,
Thank you for sending the patches over!
A few nitpicks.
> +title: SiFive fu740 PCIe host controller
> +
> +description:
> + SiFive fu740 PCIe host controller is based on the Synopsys DesignWare
> + PCI core. It shares common features with the PCIe DesignWare core and
> + inherits common properties defined in
> + Documentation/devicetree/bindings/pci/designware-pcie.txt.
[...]
In the above title and description it would be "FU740" to keep this
consistent with everything else.
Also, as this is a YAML file, a multi-line description might be better
expressed as "description: |" or "description: |+", of course it depends
on whether you would like or not to preserve line endings.
[...]
> + dma-coherent:
> + description: Indicates that the PCIe IP block can ensure the coherency
> +
> + bus-range:
> + description: Range of bus numbers associated with this controller.
[...]
> + resets:
> + description: A phandle to the PCIe power up reset line
> +
> + pwren-gpios:
> + description: Should specify the GPIO for controlling the PCI bus device power on
> +
> + perstn-gpios:
> + description: Should specify the GPIO for controlling the PCI bus device reset
[...]
All the above descriptions should end with a period, so that we keep
things consistent throughout.
Krzysztof