[PATCH v7 00/17] uvcvideo: Fix v4l2-compliance errors
From: Ricardo Ribalda
Date: Thu Mar 18 2021 - 16:30:22 EST
v4l2-compliance -m /dev/media0 -a -f
Total for uvcvideo device /dev/media0: 8, Succeeded: 6, Failed: 2, Warnings: 0
Total for uvcvideo device /dev/video0: 54, Succeeded: 50, Failed: 4, Warnings: 2
Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 102,
Failed: 6, Warnings: 2
After fixing all of them we go down to:
Total for uvcvideo device /dev/media0: 8, Succeeded: 8, Failed: 0, Warnings: 0
Total for uvcvideo device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0
Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 108,
Failed: 0, Warnings: 0
YES, NO MORE WARNINGS :)
Note that we depend on:
https://patchwork.linuxtv.org/project/linux-media/patch/20210315172531.101694-1-ribalda@xxxxxxxxxxxx/
With Hans patch we can also pass v4l2-compliance -s.
Changelog from v6 (Thanks to Hans)
- Squash all check_ext_ctrls patches
- Add documentation patch
- Return the correct ctrl_idx if the hw fails
- Fix accessible typo
- Set the proper name also for the metadata node
Hans Verkuil (1):
uvc: use vb2 ioctl and fop helpers
Ricardo Ribalda (16):
media: v4l2-ioctl: Fix check_ext_ctrls
media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL
media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL
media: uvcvideo: Set capability in s_param
media: uvcvideo: Return -EIO for control errors
media: uvcvideo: refactor __uvc_ctrl_add_mapping
media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS
media: uvcvideo: Use dev->name for querycap()
media: uvcvideo: Set unique vdev name based in type
media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE
media: uvcvideo: Use control names from framework
media: uvcvideo: Check controls flags before accessing them
media: uvcvideo: Return -EACCES to inactive controls
media: docs: Document the behaviour of uvcdriver
media: uvcvideo: Refactor __uvc_ctrl_commit
media: uvcvideo: Set error_idx during ctrl_commit errors
.../userspace-api/media/v4l/vidioc-g-ctrl.rst | 5 +
.../media/v4l/vidioc-g-ext-ctrls.rst | 5 +
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 -
drivers/media/usb/uvc/uvc_ctrl.c | 312 +++++++++++----
drivers/media/usb/uvc/uvc_driver.c | 22 +-
drivers/media/usb/uvc/uvc_metadata.c | 10 +-
drivers/media/usb/uvc/uvc_queue.c | 143 -------
drivers/media/usb/uvc/uvc_v4l2.c | 360 ++++--------------
drivers/media/usb/uvc/uvc_video.c | 13 +-
drivers/media/usb/uvc/uvcvideo.h | 53 +--
drivers/media/v4l2-core/v4l2-ioctl.c | 59 ++-
11 files changed, 408 insertions(+), 578 deletions(-)
--
2.31.0.rc2.261.g7f71774620-goog