Re: [PATCH] selftests/kvm: add get_msr_index_features

[Paolo Bonzini]

On 18/03/21 18:03, Andrew Jones wrote:
> >  TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
> > +TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features
>
> Maybe we should give up trying to keep an alphabetic order.

FWIW I had fixed that but yeah maybe we should just give up.

> > +int main(int argc, char *argv[])
> > +{
> > +	if (kvm_check_cap(KVM_CAP_GET_MSR_FEATURES))
> > +		test_get_msr_feature();
> > +
> > +	test_get_msr_index();
> Missing return
>
> > +}

"main" is special, it's okay not to have a return there.

Paolo