Re: [PATCH v2] smp: kernel/panic.c - silence warnings

From: Ingo Molnar
Date: Wed Mar 17 2021 - 16:10:34 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> Now, the C people figured that distinction was useless and allowed
> sloppiness. But I still think there's merrit to that. And as
> mentioned earlier, it is consistent with variable declarations.

Fully agreed, and my other point was that it's also consistent with
the other existing externs were used *in the same header file*
already.

I.e. there's nothing more sloppy than mixing different styles within
the same header. Checkpatch needs to be fixed or ignored here.

Thanks,

Ingo