Re: [PATCH v4 03/25] mm/vmstat: Add functions to account folio statistics

From: Christoph Hellwig
Date: Wed Mar 17 2021 - 13:17:34 EST


> +static inline
> +void __inc_zone_folio_stat(struct folio *folio, enum zone_stat_item item)

This prototype style is weird and doesn't follow either of the preffered
styles..

> static inline void __mod_zone_freepage_state(struct zone *zone, int nr_pages,
> int migratetype)
> {
> @@ -536,6 +584,24 @@ static inline void __dec_lruvec_page_state(struct page *page,
> __mod_lruvec_page_state(page, idx, -1);
> }
>
> +static inline void __mod_lruvec_folio_stat(struct folio *folio,
> + enum node_stat_item idx, int val)

.. like the ones that exist and are added by you just below.