RE: [PATCH v2] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support

[Lu, Brent]

> > +/*
> > + * rt1015:  i2c mode driver for ALC1015 and ALC1015Q
> > + * rt1015p: auto-mode driver for ALC1015, ALC1015Q, and ALC1015Q-VB
> > +*/ static const struct snd_soc_dapm_route rt1015p_1dev_dapm_routes[]
> > += {
> > +	/* speaker */
> > +	{ "Left Spk", NULL, "Speaker" },
> > +	{ "Right Spk", NULL, "Speaker" },
> > +};
> > +
> > +static const struct snd_soc_dapm_route rt1015p_2dev_dapm_routes[] = {
> > +	/* speaker */
> > +	{ "Left Spk", NULL, "Left Speaker" },
> > +	{ "Right Spk", NULL, "Right Speaker" }, };
> 
> I am confused by these routes...
> 
> is this a result of using the codec confs below only when there are 2 amps with
> their own enable pin?
Yes, we need to use the prefix in codec confs when there are two device instances.

> 
> You still have 2 amps even in the 1dev case, so I want to make sure the code has
> enough comments so that we don't lose track of the design.
> 
> The rest of the code looks fine.
> 
There are always two amps on the board for stereo output. If the two amps sharing
one enable pin, ODM will implement only one device instance in the ACPI table
because there is only one GPIO to control in codec driver.

I'll upload a v3 with more comment.


Regards,
Brent