Re: Build regressions/improvements in v5.12-rc3

[Christophe Leroy]

Le 15/03/2021 à 12:02, Geert Uytterhoeven a écrit :
> Hi Christophe,
>
> On Mon, Mar 15, 2021 at 11:55 AM Christophe Leroy
> <christophe.leroy@xxxxxxxxxx> wrote:
> > Le 15/03/2021 à 11:49, Geert Uytterhoeven a écrit :
> > > On Mon, Mar 15, 2021 at 11:46 AM Geert Uytterhoeven
> > > <geert@xxxxxxxxxxxxxx> wrote:
> > > > JFYI, when comparing v5.12-rc3[1] to v5.12-rc2[3], the summaries are:
> > > >     - build errors: +2/-2
> > >
> > > > 2 error regressions:
> > > >     + /kisskb/src/include/linux/compiler_types.h: error: call to '__compiletime_assert_248' declared with attribute error: BUILD_BUG failed:  => 320:38
> > > >     + /kisskb/src/include/linux/compiler_types.h: error: call to '__compiletime_assert_249' declared with attribute error: BUILD_BUG failed:  => 320:38
> > >
> > > powerpc-gcc4.9/ppc64_book3e_allmodconfig
> > >
> > > So we traded implicit declaration errors:
> > >
> > >     - /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:
> > > error: implicit declaration of function 'disable_kernel_vsx'
> > > [-Werror=implicit-function-declaration]: 674:2 =>
> > >     - /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:
> > > error: implicit declaration of function 'enable_kernel_vsx'
> > > [-Werror=implicit-function-declaration]: 638:2 =>
> > >
> > > for compile-time assertions.
> >
> > You are missing https://github.com/linuxppc/linux/commit/eed5fae00593ab9d261a0c1ffc1bdb786a87a55a
>
> Which is not part of v5.12-rc3.

Yes, one step at a time :)

When I did the first fix, I tested it with GCC 10 and it worked.

It is only afterwards that I saw the problem in kisskb with gcc 4.9, hence the second fix.

Christophe