Re: [PATCH v4 2/4] mtd: spi-nor: implement OTP support for Winbond and similar flashes

From: Michael Walle
Date: Mon Mar 15 2021 - 06:44:26 EST


Am 2021-03-15 09:31, schrieb Tudor.Ambarus@xxxxxxxxxxxxx:
On 3/6/21 2:05 AM, Michael Walle wrote:
+ nor->dirmap.rdesc = NULL;

why can't we use dirmap?

Dirmap is used if the controller supports (transparent)
memory mapped access, right?

As you see I'm not familiar with that, nor does my
controller has support for it, well at least the driver,
the controller supports it actually.

But it also seems like how the flash is accessed is
set up in

spi_nor_probe()
spi_nor_create_read_dirmap()

And because the read opcode has to be changed, that isn't
possible.

Plese correct me if I'm wrong.

-michael