Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

From: Andy Shevchenko
Date: Mon Mar 15 2021 - 06:17:17 EST


On Mon, Mar 15, 2021 at 10:01:47AM +0100, Bartosz Golaszewski wrote:
> On Fri, Mar 5, 2021 at 1:03 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Unfortunately while this may fix the particular use-case on STM32, it
> breaks all other users as the 'gpio-line-names' property doesn't live
> on dev_fwnode(&gdev->dev) but on dev_fwnode(chip->parent).
>
> How about we first look for this property on the latter and only if
> it's not present descend down to the former fwnode?

Oops, I have tested on x86 and it worked the same way.

Lemme check this, but I think the issue rather in ordering when we apply fwnode
to the newly created device and when we actually retrieve gpio-line-names
property.

--
With Best Regards,
Andy Shevchenko