Re: [PATCH] pcmcia: ds: Remove if with always false condition

From: Dominik Brodowski
Date: Mon Mar 15 2021 - 03:28:35 EST


Am Mon, Mar 01, 2021 at 06:38:47PM +0100 schrieb Uwe Kleine-König:
> pcmcia_device_remove() is only ever called by the driver core with
> dev->driver pointing to a valid driver. (And even if dev->driver was
> NULL, p_drv wouldn't be NULL as p_drv is assigned as follows:
>
> p_drv = to_pcmcia_drv(dev->driver);
>
> and to_pcmcia_drv is a container_of operation on struct
> pcmcia_driver::drv which isn't the first member in struct
> pcmcia_driver.)
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Applied to pcmcia-next, thanks.

Dominik