Re: [PATCH] staging: andriod: ashmem: Declared file operation with const keyword

[Nathan Chancellor]

On Sat, Mar 13, 2021 at 10:59:43PM +0530, B K Karthik wrote:
> On Sat, Mar 13, 2021 at 10:57 PM namratajanawade
> <namrata.janawade@xxxxxxxxx> wrote:
> >
> > Warning found by checkpatch.pl script.
> 
> That doesn't tell what you did or why you did it. Please write an
> appropriate commit description and resend the patch.
> 
> karthik

This patch will not even build, it has been sent several times before...

https://lore.kernel.org/r/20201016051111.1947-1-kirank.suren@xxxxxxxxx/
https://lore.kernel.org/r/20200328151523.17516-1-sandeshkenjanaashok@xxxxxxxxx/
https://lore.kernel.org/r/20201128121627.GA27317@worker-node1/
https://lore.kernel.org/r/20201227112645.256943-1-senguptaangshuman17@xxxxxxxxx/
https://lore.kernel.org/r/20201228051301.14983-1-jovin555@xxxxxxxxx/
https://lore.kernel.org/r/20210214023136.8916-1-thaiscamachoo@xxxxxxxxx/
https://lore.kernel.org/r/20210219101338.2670-1-amritkhera98@xxxxxxxxx/
https://lore.kernel.org/r/20210306063817.674041-1-nabil.ibn.mahmud@xxxxxxxxx/

I once considered adding a comment above it saying that it should not be
marked const but it is a good benchmark for seeing if people compile
their patches before sending them out.

Cheers,
Nathan