Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

[Jonathan Neuschäfer]

On Wed, Mar 10, 2021 at 09:55:45AM +0000, Lee Jones wrote:
> On Mon, 08 Mar 2021, Andreas Kemnade wrote:
[...]
> > -static const struct mfd_cell ntxec_subdevices[] = {
> > +static const struct mfd_cell ntxec_subdev[] = {
> >  	{ .name = "ntxec-rtc" },
> >  	{ .name = "ntxec-pwm" },
> >  };
> >  
> > +static const struct mfd_cell ntxec_subdev_pwm[] = {
> > +	{ .name = "ntxec-pwm" },
> > +};
> 
> To put across what you're trying to achieve, maybe call this:
> 
>   ntxec_subdev_no_rtc[]
> 
> Then if other devices are added, the semantics/intent stays the same
> and it won't have to be renamed.

Andreas, what is the full amount of functionality this version of the EC
can ever provide?

If it's only PWM, I think ntxec_subdev_pwm fits well.

[ The next subdevice that I can foresee is battery monitoring. ]


Sorry for the delay,
Jonathan

Attachment: signature.asc
Description: PGP signature