Re: [PATCH v5 08/21] selftests/resctrl: Call kselftest APIs to log test results

[Fenghua Yu]

Hi, Babu,

On Fri, Mar 12, 2021 at 01:12:35PM -0600, Babu Moger wrote:
> > -			printf("# dmesg: %s", line);
> > +			ksft_print_msg("dmesg: %s", line);
> >  		if (strstr(line, "resctrl:"))
> > -			printf("# dmesg: %s", line);
> > +			ksft_print_msg("dmesg: %s", line);
> 
> In general, this patch has some minor nits. When displaying the messages,
>  normally the first character should be capitalized.
> ksft_print_msg("checking for pass/fail\n");
> should be
>  ksft_print_msg("Checking for pass/fail\n");
> 
> And
> ksft_print_msg("Please Enter value in range 1 to %d\n",count_of_bits);
> Should be
> 
> ksft_print_msg("Please enter value in range 1 to %d\n", count_of_bits);
> 
> I am not too concerned about this. You can improve it if you like it.
> 
Ok. Will fix them.

Thanks.

-Fenghua