Re: [RFC PATCH v2 01/11] PCI/P2PDMA: Pass gfp_mask flags to upstream_bridge_distance_warn()

[Logan Gunthorpe]

On 2021-03-12 1:39 p.m., Bjorn Helgaas wrote:
> On Thu, Mar 11, 2021 at 04:31:31PM -0700, Logan Gunthorpe wrote:
> > In order to call this function from a dma_map function, it must not sleep.
> > The only reason it does sleep so to allocate the seqbuf to print
> > which devices are within the ACS path.
>
> s/this function/upstream_bridge_distance_warn()/ ?
> s/so to/is to/
>
> Maybe the subject could say something about the purpose, e.g., allow
> calling from atomic context or something?  "Pass gfp_mask flags" sort
> of restates what we can read from the patch, but without the
> motivation of why this is useful.
>
> > Switch the kmalloc call to use a passed in gfp_mask  and don't print that
> > message if the buffer fails to be allocated.
> >
> > Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

Thanks! I'll apply these changes for any future postings.

Logan