Re: [PATCH] mm: Remove default DISCONTIGMEM_MANUAL

[Mike Rapoport]

Hello Geert,

On Fri, Mar 12, 2021 at 03:12:08PM +0100, Geert Uytterhoeven wrote:
> Commit 214496cb18700fd7 ("ia64: make SPARSEMEM default and disable
> DISCONTIGMEM") removed the last enabler of ARCH_DISCONTIGMEM_DEFAULT,
> hence the memory model can no longer default to DISCONTIGMEM_MANUAL.
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Reviewed-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>

> ---
> DISCONTIGMEM_MANUAL depends on ARCH_DISCONTIGMEM_ENABLE, which in turns
> depends on BROKEN, so probably all discontig memory support can be
> removed, too?

I'm planning to remove DISCONTIGMEM entirely after 2 or 3 releases to let
the dust settle a bit after the last users of DISCONTIGMEM were switched to
other memory models.

> ---
>  mm/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 24c045b24b95069b..579254f10fb1bac6 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -9,7 +9,6 @@ config SELECT_MEMORY_MODEL
>  choice
>  	prompt "Memory model"
>  	depends on SELECT_MEMORY_MODEL
> -	default DISCONTIGMEM_MANUAL if ARCH_DISCONTIGMEM_DEFAULT
>  	default SPARSEMEM_MANUAL if ARCH_SPARSEMEM_DEFAULT
>  	default FLATMEM_MANUAL
>  	help
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.