Re: [PATCH v2 3/5] thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering

From: Lukasz Luba
Date: Fri Mar 12 2021 - 13:06:29 EST




On 3/12/21 5:03 PM, Daniel Lezcano wrote:
Currently the naming of a cooling device is just a cooling technique
followed by a number. When there are multiple cooling devices using
the same technique, it is impossible to clearly identify the related
device as this one is just a number.

For instance:

thermal-devfreq-0
thermal-devfreq-1
etc ...

The 'thermal' prefix is redundant with the subsystem namespace. This
patch removes the 'thermal' prefix and changes the number by the device
name. So the naming above becomes:

devfreq-5000000.gpu
devfreq-1d84000.ufshc
etc ...

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
---
V2:
- Removed idr.h header
- Used kasprintf instead of fixed buffer length on the stack
- Fixed typo in the log
---
drivers/thermal/devfreq_cooling.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)


Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>