Re: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros

From: Srinivas Pandruvada
Date: Fri Mar 12 2021 - 10:31:39 EST


On Fri, 2021-03-12 at 10:57 -0300, Antonio Terceiro wrote:
> These macros introduce nondeterminism in builds, and break
> reproducible
> builds.

Thanks. I will include this change in my pull request.

-Srinivas

>
> Signed-off-by: Antonio Terceiro <antonio.terceiro@xxxxxxxxxx>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> ---
> tools/power/x86/intel-speed-select/isst-config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> b/tools/power/x86/intel-speed-select/isst-config.c
> index 582feb88eca3..c50c754a656e 100644
> --- a/tools/power/x86/intel-speed-select/isst-config.c
> +++ b/tools/power/x86/intel-speed-select/isst-config.c
> @@ -2791,7 +2791,6 @@ static void usage(void)
> static void print_version(void)
> {
> fprintf(outf, "Version %s\n", version_str);
> - fprintf(outf, "Build date %s time %s\n", __DATE__, __TIME__);
> exit(0);
> }
>