Re: [PATCH 0/3] perf tools: Minor improvements in event synthesis

From: Andi Kleen
Date: Fri Mar 12 2021 - 10:10:28 EST


On Mon, Dec 21, 2020 at 04:00:26PM +0900, Namhyung Kim wrote:
> Hello,
>
> This is to optimize the event synthesis during perf record.
>
> The first patch is to reduce memory usage when many threads are used.
> The second is to avoid unncessary syscalls for kernel threads. And
> the last one is to reduce the number of threads to iterate when new
> threads are being created at the same time.
>
> Unfortunately there's no dramatic improvement here but I can see ~5%
> gain in the 'perf bench internals synthesize' on a big machine.
> (The numbers are not stable though)

Looks all good to me. The VmPeak assumption might be slightly
fragile, but I guess there's nothing better currently.

Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi