Re: [PATCH RFC v1 05/15] iommu/arm-smmu-v3: Set sync op from consumer driver of cd-lib

[Vivek Kumar Gautam]

On 3/3/21 10:45 PM, Jean-Philippe Brucker wrote:
> On Fri, Jan 15, 2021 at 05:43:32PM +0530, Vivek Gautam wrote:
> > Te change allows different consumers of arm-smmu-v3-cd-lib to set
> > their respective sync op for pasid entries.
> >
> > Signed-off-by: Vivek Gautam <vivek.gautam@xxxxxxx>
> > Cc: Joerg Roedel <joro@xxxxxxxxxx>
> > Cc: Will Deacon <will.deacon@xxxxxxx>
> > Cc: Robin Murphy <robin.murphy@xxxxxxx>
> > Cc: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>
> > Cc: Eric Auger <eric.auger@xxxxxxxxxx>
> > Cc: Alex Williamson <alex.williamson@xxxxxxxxxx>
> > Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
> > Cc: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> > Cc: Liu Yi L <yi.l.liu@xxxxxxxxx>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> > Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@xxxxxxxxxx>
> > ---
> >   drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c | 1 -
> >   drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c        | 7 +++++++
> >   2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c
> > index ec37476c8d09..acaa09acecdd 100644
> > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c
> > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c
> > @@ -265,7 +265,6 @@ struct iommu_vendor_psdtable_ops arm_cd_table_ops = {
> >   	.free	 = arm_smmu_free_cd_tables,
> >   	.prepare = arm_smmu_prepare_cd,
> >   	.write	 = arm_smmu_write_ctx_desc,
> > -	.sync	 = arm_smmu_sync_cd,
> >   };
> >   
> >   struct iommu_pasid_table *arm_smmu_register_cd_table(struct device *dev,
> > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > index 2f86c6ac42b6..0c644be22b4b 100644
> > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > @@ -1869,6 +1869,13 @@ static int arm_smmu_domain_finalise_s1(struct arm_smmu_domain *smmu_domain,
> >   	if (ret)
> >   		goto out_free_cd_tables;
> >   
> > +	/*
> > +	 * Strange to setup an op here?
> > +	 * cd-lib is the actual user of sync op, and therefore the platform
> > +	 * drivers should assign this sync/maintenance ops as per need.
> > +	 */
> > +	tbl->ops->sync = arm_smmu_sync_cd;
> > +
>
> Modifying a static struct from here doesn't feel right. I think the
> interface should be roughly similar to io-pgtable since the principle is
> the same. So the sync() op should be separate from arm_cd_table_ops since
> it's a callback into the driver. Maybe pass it to
> iommu_register_pasid_table().

Sure, will take care of this.

Thanks & regards
Vivek