Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

From: Daniel Baluta
Date: Fri Mar 12 2021 - 06:00:46 EST


On Fri, Mar 12, 2021 at 12:50 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Mar 12, 2021 at 10:32:54AM +0200, Daniel Baluta wrote:
> > On Tue, Mar 9, 2021 at 5:38 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> > > > + if (!dai_link->platforms->of_node)
> > > > + dai_link->platforms->name = component->name;
>
> > > Why would we prefer the node name over something explicitly configured?
>
> > Not sure I follow your question. I think the difference stands in the
> > way we treat OF vs non-OF platforms.
>
> If an explicit name has been provided why would we override it with an
> autogenerated one?

Wait, are you asking why the initial code:

dai_link->platforms->name = component->name;


is there in the initial code?