Re: [PATCH v2 1/2] usb: typec: tcpci: Add tcpc chip level callbacks

[Greg Kroah-Hartman]

On Fri, Mar 12, 2021 at 07:33:45AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 11, 2021 at 09:24:42PM -0800, Badhri Jagan Sridharan wrote:
> > This change adds chip callbacks for the following operations:
> > 1. Notifying port role
> > 2. Notifying orientation
> 
> This should be 2 different patches, one per callback, right?
> 
> And where is the code using these callbacks?  We can't add any hooks
> without in-tree users, as you know.

Ah, your second patch added that, sorry, missed it.

This should be a 4 patch series, remember, only do one thing per patch.

thanks,

greg k-h