Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch

From: Rong Chen
Date: Thu Mar 11 2021 - 22:51:05 EST




On 3/12/21 4:02 AM, Linus Torvalds wrote:
On Thu, Mar 11, 2021 at 11:34 AM kernel test robot <lkp@xxxxxxxxx> wrote:
kernel/gcov/geninfosize.sh: 13: [: =: unexpected operator
Wth? I'm not seeing how this can fail on nds32 - doesn't look like a
bashism, everything is properly quoted, etc etc. Plus it's a
cross-compile anyway, so the shell in question should be the same as
on all the other architectures.

Presumably the nds32 assembly contains something odd and unexpected,
but with the quoting, I can't see how even that could matter.

Yeah, the test itself could probably be simplified to testing both
conditions at the same time:

[ "$a $b" = ".size .LPBX0," ]

but that's a separate issue.

Funky. What am I missing? Presumably something really stupid.

Linus

Hi Linus,

The issue is from a=!, and [ "$a $b" = ".size .LPBX0," ] can avoid the error.

+ [ ! = .size -a ABI = .LPBX0, ]
./kernel/gcov/geninfosize.sh: 13: [: =: unexpected operator

Best Regards,
Rong Chen