Re: [PATCH v2 5/9] hwmon/drivers/mr75203: Use HZ macros

From: Guenter Roeck
Date: Thu Mar 11 2021 - 16:45:06 EST


On Wed, Feb 24, 2021 at 03:42:15PM +0100, Daniel Lezcano wrote:
> HZ unit conversion macros are available in units.h, use them and
> remove the duplicate definition.

I assume the idea is to submit the series together, so

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter

>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Reviewed-by: Christian Eggers <ceggers@xxxxxxx>
> ---
> drivers/hwmon/mr75203.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 18da5a25e89a..868243dba1ee 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -17,6 +17,7 @@
> #include <linux/property.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> +#include <linux/units.h>
>
> /* PVT Common register */
> #define PVT_IP_CONFIG 0x04
> @@ -37,7 +38,6 @@
> #define CLK_SYNTH_EN BIT(24)
> #define CLK_SYS_CYCLES_MAX 514
> #define CLK_SYS_CYCLES_MIN 2
> -#define HZ_PER_MHZ 1000000L
>
> #define SDIF_DISABLE 0x04
>