Re: [PATCH 0/2] vhost-vdpa: fix issues around v->config_ctx handling

From: Michael S. Tsirkin
Date: Thu Mar 11 2021 - 11:44:37 EST


On Thu, Mar 11, 2021 at 02:52:55PM +0100, Stefano Garzarella wrote:
> While writing a test for a Rust library [1] to handle vhost-vdpa devices,
> I experienced the 'use-after-free' issue fixed in patch 1, then I
> discovered the potential issue when eventfd_ctx_fdget() fails fixed in
> patch 2.
>
> Do you think it might be useful to write a vdpa test suite, perhaps using
> this Rust library [2] ?
> Could we put it in the kernel tree in tool/testing?

I can add tools/vdpa, no problem ...

> Thanks,
> Stefano
>
> [1] https://github.com/stefano-garzarella/vhost/tree/vdpa
> [2] https://github.com/rust-vmm/vhost
>
> Stefano Garzarella (2):
> vhost-vdpa: fix use-after-free of v->config_ctx
> vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails
>
> drivers/vhost/vdpa.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> --
> 2.29.2