Re: [PATCH] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry

From: Nishanth Menon
Date: Thu Mar 11 2021 - 07:57:15 EST


On 19:36-20210310, Bajjuri, Praneeth wrote:
>
>
> On 2/20/2021 6:49 AM, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> >
> > Add the DT entry for a watchdog based on RTI1.
> >
> > On SR1.0 silicon, it requires additional firmware on the MCU R5F cores
> > to handle the expiry, e.g. https://github.com/siemens/k3-rti-wdt. As
> > this firmware will also lock the power domain to protect it against
> > premature shutdown, mark it shared.
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>
> Acked-by: Praneeth Bajjuri <praneeth@xxxxxx>
>
> > ---
> > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > index 7454c8cec0cc..903796bf7d64 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> > @@ -308,4 +308,13 @@ mcu_r5fss0_core1: r5f@41400000 {
> > ti,loczrama = <1>;
> > };
> > };
> > +
> > + mcu_rti1: rti@40610000 {

Jan, I was about to pick up the patches and was running through
my sanity checks and the following caught my eye with dtbs_check
(dtschema is at 2021.2.1) test against next-20210311

/workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: rti@40610000: $nodename:0: 'rti@40610000' does not match '^watchdog(@.*|-[0-9a-f])?$'

Please use watchdog@40610000 instead of rti@40610000

Since this is a minor change, I have done this change locally. let me
know if you have an issue and I can drop it off my branch for a new
version.

[...]

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D