Re: [PATCH v2 1/5] drm: Add and export function drm_gem_cma_create_noncoherent

[Christoph Hellwig]

> +static struct drm_gem_cma_object *
> +drm_gem_cma_create_with_cache_param(struct drm_device *drm,
> +				    size_t size,
> +				    bool noncoherent)

Does this helper really make much sense?  You basically have two
function calls in it, out of which one is dependend on the parameter.