Re: [RFC v2 5/5] clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks

From: Krzysztof Kozlowski
Date: Thu Mar 11 2021 - 02:30:51 EST


On 10/03/2021 17:48, Arnd Bergmann wrote:
> On Wed, Mar 10, 2021 at 9:38 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>> --- a/drivers/clk/socfpga/Kconfig
>> +++ b/drivers/clk/socfpga/Kconfig
>> @@ -1,6 +1,17 @@
>> # SPDX-License-Identifier: GPL-2.0
>> +config COMMON_CLK_SOCFPGA
>> + bool "Intel SoCFPGA family clock support" if COMPILE_TEST && !ARCH_SOCFPGA && !ARCH_SOCFPGA64
>> + depends on ARCH_SOCFPGA || ARCH_SOCFPGA64 || COMPILE_TEST
>> + default y if ARCH_SOCFPGA || ARCH_SOCFPGA64
>
> I think the 'depends on' line here is redundant if you also have the
> 'if' line and the default.

Yes, you're right.
Best regards,
Krzysztof