Re: [PATCH v4 6/7] dt-bindings: interrupt-controller: Add Loongson-2K1000 LIOINTC

[zhangqing]

On 03/10/2021 08:04 PM, Jiaxun Yang wrote:
> On Wed, Mar 10, 2021, at 3:56 PM, Qing Zhang wrote:
> > Add liointc-2.0 properties support, so update the maxItems and description.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> ^ I have nothing todo with this patch so please drop me for this one :-)
>
> > Signed-off-by: Qing Zhang <zhangqing@xxxxxxxxxxx>
> > Tested-by: Ming Wang <wangming01@xxxxxxxxxxx>
> > ---
> >
> > v3-v4: Standard submission of information
> ^ It's called commit message.
>
> >   .../bindings/interrupt-controller/loongson,liointc.yaml    | 7 ++++---
> >   1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> > index f38e0113f360..5280cf60a9a7 100644
> > ---
> > a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> > +++
> > b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
> > @@ -10,9 +10,9 @@ maintainers:
> >     - Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> >   
> >   description: |
> > -  This interrupt controller is found in the Loongson-3 family of chips
> > as the primary
> > -  package interrupt controller which can route local I/O interrupt to
> > interrupt lines
> > -  of cores.
> > +  This interrupt controller is found in the Loongson-3 family of chips
> > and
> > +  Loongson-2K1000 chip, as the primary package interrupt controller
> > which
> > +  can route local I/O interrupt to interrupt lines of cores.
> >   
> >   allOf:
> >     - $ref: /schemas/interrupt-controller.yaml#
> > @@ -22,6 +22,7 @@ properties:
> >       oneOf:
> >         - const: loongson,liointc-1.0
> >         - const: loongson,liointc-1.0a
> > +      - const: loongson,liointc-2.0
> >   
> >     reg:
> >       maxItems: 1
> ^ Please document multiple reg prop change as well.
  Hi, Jiaxun

  Thank you for your reply,

  I will do it and send v5.

  Thanks,
  -Qing
> Thanks.
>
> - Jiaxun
>
> > --
> > 2.20.1