Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

From: Linus Walleij
Date: Wed Mar 10 2021 - 18:14:51 EST


On Thu, Mar 4, 2021 at 8:49 PM Jonathan Marek <jonathan@xxxxxxxx> wrote:

> If these fields are not set in dts, the driver will use these variables
> uninitialized to set the fields. Not only will it set garbage values for
> these fields, but it can overflow into other fields and break those.
>
> In the current sm8250 dts, the dmic01 entries do not have a pullup setting,
> and might not work without this change.
>
> Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
> Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>

Patch applied for fixes!

Yours,
Linus Walleij