Re: [RFT PATCH v3 25/27] tty: serial: samsung_tty: Add earlycon support for Apple UARTs

[Linus Walleij]

On Thu, Mar 4, 2021 at 10:42 PM Hector Martin <marcan@xxxxxxxxx> wrote:

> Earlycon support is identical to S3C2410, but Apple SoCs also need
> MMIO mapped as nGnRnE. This is handled generically for normal drivers
> including the normal UART path here, but earlycon uses fixmap and
> runs before that scaffolding is ready.
>
> Since this is the only case where we need this fix, it makes more
> sense to do it here in the UART driver instead of introducing a
> whole fdt nonposted-mmio resolver just for earlycon/fixmap.
>
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Hector Martin <marcan@xxxxxxxxx>

This is as elegant as it gets!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij